Fix default initialization for various types#104
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 92.12% 92.46% +0.33%
==========================================
Files 20 20
Lines 2146 2176 +30
==========================================
+ Hits 1977 2012 +35
+ Misses 169 164 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
force-pushed
the
fix-default-initialization
branch
3 times, most recently
from
64b3675 to
6b45db8
Compare
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
twiggler
reviewed
Oct 23, 2024
Schamper
force-pushed
the
fix-default-initialization
branch
2 times, most recently
from
f77e77c to
f8503a4
Compare
Schamper
force-pushed
the
fix-default-initialization
branch
2 times, most recently
from
cd2ad25 to
a31c4e7
Compare
Schamper
force-pushed
the
fix-default-initialization
branch
from
a31c4e7 to
79d1698
Compare
twiggler
approved these changes
Oct 24, 2024
Contributor
twiggler
left a comment
twiggler
left a comment
There was a problem hiding this comment.
Nice!
Lked the "concept checks" like is_readable_type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102 and the bug that occurred in fox-it/dissect.hypervisor#31.